test: add integration tests and refactor

src/app.js

@@ -18,5 +18,8 @@ export default async (app, { getRouter }) => {
   app.on("issues.opened", issue_opened);
 
   // Comment is created in an issue by a user
-  app.on("issue_comment.created", issue_comment_created);
+  app.on(
+    ["issue_comment.created", "issue_comment.edited"],
+    issue_comment_created
+  );
 };

src/handlers/issue_comment_created.js

@@ -12,16 +12,21 @@ export default async (context) => {
   const collaboratorsJson = await context.octokit.repos.listCollaborators(
     context.repo({})
   );
-  const collaborators = collaboratorsJson.data.map((coll) => coll.login);
+  const collaborators = collaboratorsJson.data
+    .filter((coll) => {
+      return (
+        coll.permissions.admin ||
+        coll.permissions.maintain ||
+        coll.permissions.triage
+      );
+    })
+    .map((coll) => coll.login);
 
   if (skipCommenters(commenter, collaborators)) return;
 
   const config = await getConfig(context);
-  const assignPromptKey = "assign-prompt";
-  const unassignPromptKey = "unassign-prompt";
 
   const assignees = issue.assignees.map((assigneeJson) => assigneeJson.login);
-  const assigneeCount = assignees.length;
 
   const request = checkRequest(comment.body, config);
   if (request === Request.SKIP) return;

src/handlers/issue_opened.js

@@ -6,7 +6,15 @@ export default async (context) => {
   const collaboratorsJson = await context.octokit.repos.listCollaborators(
     context.repo({})
   );
-  const collaborators = collaboratorsJson.data.map((coll) => coll.login);
+  const collaborators = collaboratorsJson.data
+    .filter((coll) => {
+      return (
+        coll.permissions.admin ||
+        coll.permissions.maintain ||
+        coll.permissions.triage
+      );
+    })
+    .map((coll) => coll.login);
   const issue_opener_username = issue.user.login;
 
   const config = await getConfig(context);
@@ -17,8 +25,17 @@ export default async (context) => {
     issue_opener_username
   );
   if (issue_opener === OpenerIsMaintainer.SKIP) return;
-  const issueComment = context.issue({
-    body: `@${issue_opener} ` + config[issue_opener],
-  });
-  return await context.octokit.issues.createComment(issueComment);
+  if (issue_opener === OpenerIsMaintainer.YES) {
+    return await context.octokit.issues.createComment(
+      context.issue({
+        body: config[issue_opener],
+      })
+    );
+  } else {
+    return await context.octokit.issues.createComment(
+      context.issue({
+        body: `@${issue_opener_username} ` + config[issue_opener],
+      })
+    );
+  }
 };

src/helpers/check_request.js

@@ -9,11 +9,11 @@ export function checkRequest(comment, config) {
     .replace(/\s+/g, " ") // trim whitespace
     .toLowerCase(); // Case insensitive
 
-  if (config[Request.ASSIGN]) {
-    if (comment.includes(config[Request.ASSIGN])) return Request.ASSIGN;
-    else return Request.SKIP;
-  } else if (config[Request.UNASSIGN]) {
-    if (comment.includes(config[Request.UNASSIGN])) return Request.UNASSIGN;
-    else return Request.SKIP;
-  } else return Request.SKIP;
+  if (config[Request.ASSIGN] && comment.includes(config[Request.ASSIGN])) {
+    return Request.ASSIGN;
+  }
+  if (config[Request.UNASSIGN] && comment.includes(config[Request.UNASSIGN])) {
+    return Request.UNASSIGN;
+  }
+  return Request.SKIP;
 }

src/helpers/get_assigned_issues.js

@@ -2,7 +2,7 @@
 export default async function getAssignedIssues(context, username) {
   try {
     const response = await context.octokit.issues.listForRepo(
-      context.issue({
+      context.repo({
         assignee: username,
         state: "open",
       })

src/server.js

@@ -1,3 +1,4 @@
+import { run } from "probot";
 import app from "./app.js";
 
 run(app);

test/fixtures/issue_comment.created.json

@@ -0,0 +1,20 @@
+{
+  "action": "created",
+  "issue": {
+    "number": 1
+  },
+  "repository": {
+    "name": "test-repo",
+    "owner": {
+      "login": "test-owner"
+    }
+  },
+  "comment": {
+    "user": {
+      "login": "test"
+    }
+  },
+  "installation": {
+    "id": 2
+  }
+}