Usage information shown after a command fails is now significantly less intrusive #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSauce04
changed the title
|
We should not change what's inside the vendor path. A better approach would be sending the PR to upstream. Do you know other methods to implement this? |
|
I thought the same when I first did this but one of the other Vanilla developers said that it was fine so I just left it as is. Can probably look into another method of doing this in the coming days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of showing the entire usage page for the command and showing the exit code twice for some reason, the message now shows significantly more concise usage information as well as only displaying the error code once.
This makes it much easier to actually see what went wrong as opposed to being blasted with
helpinformation and having to scroll upwards to actually see what the error wasThis PR:
Current:
