Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate property text_inset entry in HudHistoryResource. #579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

malortie
Copy link

@malortie malortie commented May 5, 2024

This removes a duplicate text_inset. The one with value 36 is kept.

In older versions, it was set to 26. Below is the version found in Depot 212 (Base Source Engine 2).

hl2/scripts/hudlayout.res
HudHistoryResource
{
	"fieldName" "HudHistoryResource"
	"visible" "1"
	"enabled" "1"
	"xpos"	"r252"
	"ypos"	"40"
	"wide"	 "248"
	"tall"	 "320"

	"history_gap"	"56"
	"icon_inset"	"28"
	"text_inset"	"26"
	"NumberFont"	"HudNumbersSmall"
}

Later, it appears to have been changed to 36. Of note, Half-Life 2: Deathmatch still uses 26.

Depot 211 (Source SDK) contains a hudlayout.res file in which text_inset is set to 36 with no duplicate.

launcher/createmodfiles/orangebox/singleplayer/scripts/hudlayout.res
HudHistoryResource	[$WIN32]
{
	"fieldName" "HudHistoryResource"
	"visible" "1"
	"enabled" "1"
	"xpos"	"r252"
	"ypos"	"40"
	"wide"	 "248"
	"tall"	 "320"

	"history_gap"	"56"
	"icon_inset"	"38"
	"text_inset"	"36"
	"NumberFont"	"HudNumbersSmall"
}

mod_episodic's HUD layout has no duplicate and uses 36 as value, so this should probably be the same.

HudHistoryResource [$WIN32]
{
"fieldName" "HudHistoryResource"
"visible" "1"
"enabled" "1"
"xpos" "r252"
"ypos" "40"
"wide" "248"
"tall" "320"
"history_gap" "56" [!$OS]
"history_gap" "64" [$OSX]
"icon_inset" "38"
"text_inset" "36"
"NumberFont" "HudNumbersSmall"
}

Copy link

@Nurmalitafitriansyah Nurmalitafitriansyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -423,7 +423,6 @@
"history_gap" "64" [$OSX]
"icon_inset" "38"
"text_inset" "36"
"text_inset" "26"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f8ac680b9770327ca7e1c14960e17faa4b8c6491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants