drm: fix wrong degamma/shaper TFs on NV12 #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For BT.709, the AMD driver-specific color management properties define the inverse OETF for plane degamma and blend predefined TFs and the OETF for plane shaper and CRTC regamma TFs. By correctly setting degamma and shaper TFs to NV12 planes, we can bring degamma and shaper+3D LUT back and remove the workaround made in [1]. [1] 3b69847 ("drm: Add workaround for NV12 scanout on SteamOS 3.6")
|
Thanks for catching, makes sense... EOTF vs inv_OETF is e_e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For BT.709, AMD driver-specific color management properties define the inverse OETF for plane degamma and blend predefined TFs and the OETF for plane shaper and CRTC regamma TFs, as in drm_info:
By correctly setting degamma and shaper TFs to NV12 planes, we can bring degamma and shaper+3D LUT back and remove the workaround made in [1].
[1] 3b69847 ("drm: Add workaround for NV12 scanout on SteamOS 3.6")