Workaround steam overlay's issues with attaching to wayland windows to allow steam overlay/input in nested mode

[VoidAndCaffeine]

It is a very hacky solution but is only needed until valve fixes steam overly to properly work on wayland windows. See #1225 for more info

[misyltoad]

This doesn't work though, I already tried it, the overlay opens once then breaks mouse input for the rest of the game.

[VoidAndCaffeine]

what game did you use to test? on my system it works with Elden ring and cyberpunk I haven't tested with anything else. I assume you are on KDE as well?

[VoidAndCaffeine]

my launch opts are gamescope -f -h 1440 -r 165 --hdr-enabled --overlay-workaround -- %command%. my other thought is that rather than a dedicated option it could be tied to there not being a -e but that might cause unintended issues.
also with the workaround -e has no effect input to the game.
also also I totally understand if this workaround is to hacky to be merged.

[misyltoad]

Sorry for taking a while got get back.

I tested Helldivers 2.

[VoidAndCaffeine]

Interesting I don't own that so i haven't tried it. Does it have an anticheet window that could be interfering with the overlay attaching to the game?

I have been using this pr since i submitted it an have had no issues. tested with:
Dark souls Remasterd, 2, & 3
Monster hunter world
Elden ring
Sunless Skies
a new life.
missed messages.
Stardew Valley
WILD HEARTS
Cyberpunk 2077
Witcher 3
Quake II RTX
Getting Over It
and Dragons Dogma 2

[anthr76]

Just wanted to say I tested this on Halo Infinite and Doom Eternal and so far the results are very promising. Even if it's a hack thanks much for the patch.

[misyltoad]

Does it have an anticheet window that could be interfering with the overlay attaching to the game?

Yes it does, it has an invisible window that appears above the whole game.

[anthr76]

@VoidAndCaffeine this patch requires a rebase.

[tlneondo]

Just tested the patch on the version shipped with fedora, no compilation issues, will test tonight when i get home.

[tlneondo]

I patched the fedora version and it got controller input working again, but i started getting freezes, especially when the steam overlay popped up. So I'm wondering if my issue is different.

[anthr76]

This patch has worked wonders for me. Pretty surprising hearing varying amounts of success here. I do run off of nightly builds.

[sharkautarch]

@tlneondo

I patched the fedora version… started getting freezes

I’m not sure if this is the case or not, but could fedora’s gamescope package be using the system’s wlroots? Note that Joshua Ashton did push a commit last week to try to discourage packagers from doing so (7741cd5)

To check, run ldd $(which gamescope)
and see if you see wlroots show up
(if you see wlroots listed there, then the packager probably built gamescope linked to the system’s wlroots)

[anthr76]

As of 09cb7b4 it seems I don't need this patch anymore! Will confirm otherwise.

Nevermind I was running the wrong binary