Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(leds):spiked leds #136

Closed
wants to merge 2 commits into from
Closed

Feat(leds):spiked leds #136

wants to merge 2 commits into from

Conversation

Mau38
Copy link
Contributor

@Mau38 Mau38 commented Mar 22, 2023

Leds blink rapidly when the intake is spiked.

@Mau38 Mau38 self-assigned this Mar 22, 2023
@Mau38 Mau38 added the Needs Testing Needs to be tested before merge label Mar 22, 2023
@Mau38 Mau38 requested a review from a team March 22, 2023 16:42
@janhelgeson janhelgeson linked an issue Mar 22, 2023 that may be closed by this pull request
Flash LED's Red when gamepiece is aquired #129
Open
mray190
mray190 requested changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@mray190 mray190 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be 2 candle devices with the same CAN address in memory. Instead, create the CANdle object in robot.cpp and pass the reference down to each subsystem that uses it. Then have to be careful about race conditions

@Mau38 Mau38 closed this Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mray190 mray190 mray190 requested changes

Assignees

@Mau38 Mau38

Labels
Needs Testing Needs to be tested before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flash LED's Red when gamepiece is aquired
2 participants
@Mau38 @mray190