Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(1.95): update patches #2055

Merged
merged 14 commits into from
Oct 13, 2024
Merged

feat(1.95): update patches #2055

merged 14 commits into from
Oct 13, 2024

Conversation

daiyam
Copy link
Member

@daiyam daiyam commented Oct 10, 2024

No description provided.

@daiyam daiyam merged commit 7578449 into VSCodium:insider Oct 13, 2024
19 checks passed
@daiyam
Copy link
Member Author

daiyam commented Oct 13, 2024

@lex-ibm Hi, I have disabled ppc64 build.
Because the dependency @vscode/policy-watcher is using the gcc's flag -std=gnu++20, so I have updated to gcc-10.
I'm not sure how to update the sysroot, if you could do it, it would be great.

@daiyam daiyam deleted the feat-195 branch October 13, 2024 18:21
@lex-ibm
Copy link
Contributor

lex-ibm commented Oct 14, 2024

Roger that, will get this out asap

@lex-ibm
Copy link
Contributor

lex-ibm commented Oct 14, 2024

@daiyam I saw the focal-ppc64le build failed, but I was able to build it in my local. Was qemu enabled for that job?

@lex-ibm
Copy link
Contributor

lex-ibm commented Oct 14, 2024

I believe this line is missing focal-ppc64le

@daiyam
Copy link
Member Author

daiyam commented Oct 14, 2024

I believe this line is missing focal-ppc64le

yep!

@daiyam
Copy link
Member Author

daiyam commented Oct 14, 2024

From https://github.com/VSCodium/vscodium/actions/runs/11328290273/job/31501917695, it's still using the gcc of the sysroot (gcc-8.5), define in the patch (export CC=$VSCODE_SYSROOT_DIR/powerpc64le-linux-gnu/bin/powerpc64le-linux-gnu-gcc).
In #2059, I'm trying to see if we can avoid the sysroot since riscv64 do compile without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants