Skip to content

Commit

Permalink
feat(1.82): update patches and use node-v18 (#1626)
Browse files Browse the repository at this point in the history
  • Loading branch information
daiyam authored Sep 3, 2023
1 parent 6f36a98 commit 61f4931
Show file tree
Hide file tree
Showing 11 changed files with 81 additions and 75 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/insider-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ on:
env:
APP_NAME: VSCodium
ASSETS_REPOSITORY: ${{ github.repository }}-insiders
GITHUB_BRANCH: insider
GITHUB_BRANCH: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || 'insider' }}
OS_NAME: linux
VERSIONS_REPOSITORY: ${{ github.repository_owner }}/versions
VSCODE_QUALITY: insider
Expand Down Expand Up @@ -231,7 +231,7 @@ jobs:
steps:
- uses: actions/checkout@v3
with:
ref: insider
ref: ${{ env.GITHUB_BRANCH }}

- name: Check version
env:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/insider-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ on:
env:
APP_NAME: VSCodium
ASSETS_REPOSITORY: ${{ github.repository }}-insiders
GITHUB_BRANCH: insider
GITHUB_BRANCH: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || 'insider' }}
OS_NAME: osx
VERSIONS_REPOSITORY: ${{ github.repository_owner }}/versions
VSCODE_QUALITY: insider
Expand All @@ -48,12 +48,12 @@ jobs:
steps:
- uses: actions/checkout@v3
with:
ref: insider
ref: ${{ env.GITHUB_BRANCH }}

- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'

- name: Clone VSCode repo
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/insider-spearhead.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'

- name: Clone VSCode repo
run: . get_repo.sh
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/insider-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ on:
env:
APP_NAME: VSCodium
ASSETS_REPOSITORY: ${{ github.repository }}-insiders
GITHUB_BRANCH: insider
GITHUB_BRANCH: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || 'insider' }}
OS_NAME: windows
VERSIONS_REPOSITORY: ${{ github.repository_owner }}/versions
VSCODE_QUALITY: insider
Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'

- name: Install Yarn
run: npm install -g yarn
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stable-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'

- name: Clone VSCode repo
run: . get_repo.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stable-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '18'

- name: Install Yarn
run: npm install -g yarn
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.20
18.15
2 changes: 1 addition & 1 deletion get_repo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,4 @@ fi

export MS_TAG
export MS_COMMIT
export RELEASE_VERSION
export RELEASE_VERSION
5 changes: 4 additions & 1 deletion insider.json
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@

{
"tag": "1.82.0",
"commit": "f1302be1e67e3af5fbeb8bbb2ea784de7bc96150"
}
107 changes: 58 additions & 49 deletions patches/brand.patch

Large diffs are not rendered by default.

20 changes: 7 additions & 13 deletions patches/fix-eol-banner.patch
Original file line number Diff line number Diff line change
Expand Up @@ -48,21 +48,15 @@ index b120c94..1bb2b88 100644
+
toJSON(): object {
diff --git a/src/vs/workbench/electron-sandbox/window.ts b/src/vs/workbench/electron-sandbox/window.ts
index cf6af9d..108ce8f 100644
index 1efcf6b..b52830c 100644
--- a/src/vs/workbench/electron-sandbox/window.ts
+++ b/src/vs/workbench/electron-sandbox/window.ts
@@ -725,3 +725,4 @@ export class NativeWindow extends Disposable {
actions,
- icon: Codicon.warning
+ icon: Codicon.warning,
+ neverShowAgain: { id: 'windowseol', isSecondary: true, scope: NeverShowAgainScope.APPLICATION }
});
@@ -764,3 +765,4 @@ export class NativeWindow extends Disposable {
actions,
- icon: Codicon.warning
+ icon: Codicon.warning,
+ neverShowAgain: { id: 'macoseol', isSecondary: true, scope: NeverShowAgainScope.APPLICATION }
});
@@ -738,3 +738,4 @@ export class NativeWindow extends Disposable {
actions,
- icon: Codicon.warning
+ icon: Codicon.warning,
+ neverShowAgain: { id: 'windowseol', isSecondary: true, scope: NeverShowAgainScope.APPLICATION }
});
diff --git a/src/vs/workbench/services/banner/browser/bannerService.ts b/src/vs/workbench/services/banner/browser/bannerService.ts
index 639b1b2..70e8847 100644
--- a/src/vs/workbench/services/banner/browser/bannerService.ts
Expand Down

0 comments on commit 61f4931

Please sign in to comment.