feat: round numbers to reduce undeterministic behavior #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
scanny
force-pushed
the
feat/round-floating-point-number-before-computation
branch
from
826186b
to
669d717
Compare
scanny
deleted the
feat/round-floating-point-number-before-computation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rounds the floating point number associated with coordinates in
pdfminer_processing.py. This helps to eliminate machine precision caused randomness in bounding box overlap detection. Currently the rounding is set to the nearest machine precision fornp.float32usingnp.finfo(float), which yields resolution =1e-15.future work
We should reduce the rounding to only 6 digits after floating point since the data type
float32has a resolution of only1e-6. However it would break tests. A followup is required to tune the threshold values inpdfminer_processing.pyso that it works with1e-6resolution.