remove abstract decorator from initialize in BaseEmbeddingEncoder #3730
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Oct 18, 2024
| @@ -15,7 +15,6 @@ class EmbeddingConfig(BaseModel): | |||
| class BaseEmbeddingEncoder(ABC): | |||
| config: EmbeddingConfig | |||
|
|
|||
| @abstractmethod | |||
There was a problem hiding this comment.
Matches the implementation of BaseEmbeddingEncoder in unstructured_ingest: https://github.com/Unstructured-IO/unstructured-ingest/blob/main/unstructured_ingest/embed/interfaces.py#L16
mattseddon
force-pushed
the
remove-abstract-decorator
branch
5 times, most recently
from
58c50b4
to
d8cad90
Compare
mattseddon
force-pushed
the
remove-abstract-decorator
branch
from
d8cad90
to
deb4c4e
Compare
|
@MKhalusova, can you help me get this reviewed?... please 🙏🏻🙏🏻🙏🏻. The DataChain unstructured examples (here and here) are currently stuck on an older version of Unstructured because of #3731 and this change should close that issue. |
|
@cragwolfe would this 👇🏻 be the correct format for the changelog entry? 0.16.5-dev0EnhancementsFeaturesFixes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3731. Please see the issue for details.
Comments inline.