Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect document language across all partitioners #1627

Merged
merged 95 commits into from
Oct 11, 2023
Merged

Conversation

Coniferish
Copy link
Collaborator

@Coniferish Coniferish commented Oct 3, 2023

Summary

Closes #1534 and #1535
Detects document language using langdetect package.
Creates new kwargs for user to set the document language (languages) or detect the language at the element level instead of the default document level (detect_language_per_element)

@shreyanid
Copy link
Contributor

just realized the auto partitioner was not yet updated - we need to pass the languages parameter through to each partitioner

@shreyanid
Copy link
Contributor

also please bump dev version in CHANGELOG and unstructured/__version__.py

Copy link
Contributor

@shreyanid shreyanid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm! update final changelog version / fix all conflicts and tests before merging

@awalker4 awalker4 added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit 9500d04 Oct 11, 2023
39 checks passed
@awalker4 awalker4 deleted the jj/1534-doc-lvl-lang branch October 11, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat/finish implementing document level language detection for other doctypes
6 participants