Roman/s3 minio all cloud support #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbiseck3
force-pushed
the
roman/s3-minio-all-cloud-support
branch
from
5f9d745
to
5586096
Compare
rbiseck3
added
enhancement
rbiseck3
force-pushed
the
roman/s3-minio-all-cloud-support
branch
from
fbfd1f3
to
45f420a
Compare
jasonbot
reviewed
Oct 3, 2023
| @@ -32,6 +34,13 @@ def add_cli_options(cmd: click.Command) -> None: | |||
| default=False, | |||
| help="Connect to s3 without local AWS credentials.", | |||
| ), | |||
| click.Option( | |||
| ["--endpoint-url"], | |||
This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rbiseck3 <[email protected]>
rbiseck3
force-pushed
the
roman/s3-minio-all-cloud-support
branch
from
386e0a5
to
7c1f9d6
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposes the endpoint url as an access kwarg when using the s3 filesystem library via the fsspec abstraction. This allows for any non-aws data providers that support the s3 protocol to be used with the s3 connector (i.e. minio)
Closes out #950