-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/add sources from unstructured inference #1538
Merged
benjats07
merged 57 commits into
main
from
benjamin/feat/add-sources-from-unstructured-inference
Oct 5, 2023
Merged
Changes from 43 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
3ae41c1
Changelog update
b31358c
CHANGELOG update
0dfbd90
feat: add support for store unstructured-infrence data sources
8320d49
refactor: change import location
f9ab8c9
lining
9bab134
fix: handles sources of non-hi_res elements
3b07daf
fix: correctly query dictionary
51d7257
Benjamin/feat/add sources from unstructured inference <- Ingest test …
ryannikolaidis 2de6040
feat: add data_origin to all document elements
ef2f019
fix: add type ignore
44c5fb4
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 12b30a0
test: fix reference object
786ab88
fix: corrected image source
64ca051
feat/add sources from unstructured inference <- Ingest test fixtures …
ryannikolaidis e700182
feat: add missing origins
ca23d44
test: add tests for checking source of elements on all types
15f42d4
linting
fe3671d
fix: remove data_origin from JSON outputs
ba194c7
fix: remove variable naming containing _source_
a265d0b
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 3f0618b
feat/add sources from unstructured inference <- Ingest test fixtures …
ryannikolaidis f3d7d07
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 b186c5d
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 0d9bcd5
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 60992bb
Update CHANGELOG
7e95e48
refactor: makes data_source optional field
30a64f6
refactor: uses setattr for data_source
8ee672e
Linting
b7cc62b
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 8b03bf3
refactor: delete lines checking for debug variable
a423cf5
fix: add debug variable to test-no-extras
1ed45a5
fix: missing env variable assignation
25f54a6
fix: missing env variable assignation
7e4b5a3
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 a73bf65
refactor: change way to asign data_origin
61d3a4a
test: update tests for checking data_origin
95d9378
fix: missing data_origin on some elements
bb47079
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 164963d
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 860af76
refactor: change data_origin by detection_origin
63ef0ee
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 861d9ac
linting
1e7a085
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 9065e4e
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 c16b79c
linting
9dfa83a
fix: new elements missed detection_origin
b8d5167
Version and changelog update
519dba1
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 5c1d31d
fix: recovered line lost when merging main
0b0d68b
fix: variable incorrectly setted
2fb50ac
refactor: returns objects directly
2b4110d
refactor: change detection_origin by constants
73bd60a
feat/add sources from unstructured inference <- Ingest test fixtures …
ryannikolaidis fbb3e3f
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 e3ed76a
Merge branch 'main' into benjamin/feat/add-sources-from-unstructured-…
benjats07 1a9a303
linting
5fc6e82
Changelog update
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 0 additions & 15 deletions
15
...ctured_ingest/expected-structured-output/notion/9e20be3d-cbe0-4e28-ad46-2170d40a8d37.json
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use mocker to set the constant to true so we are certain this is tested; I understand that in the ci we set the env variable so this is tested in CI but this if statement here can cause confusion for local testing vs. ci; and potentially have code silently fail if ci for some reason dropped the env