Adds data source properties to git connectors #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryannikolaidis
added
the
ingest
… update (#1344) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rvztz <[email protected]>
… update (#1358) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rvztz <[email protected]>
…IO/unstructured into data-source-properties-git
test_unstructured_ingest/expected-structured-output/github/LICENSE.txt.json
Outdated
Show resolved
Hide resolved
ryannikolaidis
requested changes
Sep 21, 2023
… update (#1491) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rvztz <[email protected]>
test_unstructured_ingest/expected-structured-output/github/LICENSE.txt.json
Outdated
Show resolved
Hide resolved
… update (#1554) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rvztz <[email protected]>
…IO/unstructured into data-source-properties-git
| @@ -1,28 +0,0 @@ | |||
| [ | |||
There was a problem hiding this comment.
this looks like a bug, this shouldn't be removed. try re-running fixtures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds data source properties to git connectors:
These properties are instantiated when supported by the connector.
Separates the logic between fetching the file from source and
get_file. Retrieves file metadata when any of the properties are called.Adds logic to check if file exists in the remote source. For connectors that don't directly support it, adds exception handling to check any issues while retrieving the file.