Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean tests usage of endpoints #158

Merged
merged 8 commits into from
Dec 11, 2023

Conversation

chriswk
Copy link
Contributor

@chriswk chriswk commented Dec 6, 2023

Previously, once we hit the feature refresh interval, we saw failed requests against https://localhost:4242, this update replaces all usages in these tests with the gocked url instead of a fake localhost address

Previously, once we hit the feature refresh interval, we saw failed
requests against https://localhost:4242, this update replaces all usages
in these tests with the gocked url instead of a fake localhost address
Copy link
Contributor

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chriswk chriswk merged commit 34874e1 into v4 Dec 11, 2023
9 checks passed
@chriswk chriswk deleted the chore/stopTestsFromHittingLocalhost branch December 11, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants