Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix to wrench hw interface #217

Merged

Conversation

carebare47
Copy link
Contributor

Adds a prefix to the wrench hw interface so that multiple arms can have their force torque sensors used at the same time

@fmauch
Copy link
Collaborator

fmauch commented Jul 3, 2020

I think, it would be better to either use the tf_prefix or use a parameter for the complete interface name.

@carebare47
Copy link
Contributor Author

I think, it would be better to either use the tf_prefix or use a parameter for the complete interface name.

6e21e0d

@fmauch
Copy link
Collaborator

fmauch commented Jul 3, 2020

Do you think, it would make sense to read it from the root node handle, similar to joint_names, then we could configure this together with instanciating the controller in https://github.com/UniversalRobots/Universal_Robots_ROS_Driver/blob/master/ur_robot_driver/config/ur10_controllers.yaml#L21

In my opinion that would be preferable over introducing yet another launch file parameter.

@fmauch
Copy link
Collaborator

fmauch commented Jul 3, 2020

Also, once everything is in place, we should make sure that documentation is everywhere at the right places, e.g. here

@carebare47
Copy link
Contributor Author

Do you think, it would make sense to read it from the root node handle, similar to joint_names, then we could configure this together with instanciating the controller in https://github.com/UniversalRobots/Universal_Robots_ROS_Driver/blob/master/ur_robot_driver/config/ur10_controllers.yaml#L21

In my opinion that would be preferable over introducing yet another launch file parameter.

I think that would cause us a similar problem to the one we have here: #110

@gavanderhoorn
Copy link
Contributor

This doesn't appear to be setting a prefix any more, but it configures the actual frame_id value.

Suggestion: use wrench_frame_id as the name everywhere (ie: parameter name, local member variable, etc).

@carebare47
Copy link
Contributor Author

This doesn't appear to be setting a prefix any more, but it configures the actual frame_id value.

Suggestion: use wrench_frame_id as the name everywhere (ie: parameter name, local member variable, etc).

That's nicer, thanks

@carebare47
Copy link
Contributor Author

Also, once everything is in place, we should make sure that documentation is everywhere at the right places, e.g. here

91d31f5

Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fmauch fmauch merged commit 72453e1 into UniversalRobots:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants