Fix: Broken explorer links on Pool page #308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…explorer link on pool page
0xTARC
changed the title
0xTARC
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Explorer links on PoolPage are always linking to etherscan.io, regardless of the chosen chain
Link out before fix:
https://github.com/Uniswap/v3-info/assets/97852365/e032e098-4c76-450d-9ac5-15f8aeead3bf
Solution
Use the active chain's network id when building explorer link
Link out after fix:
https://github.com/Uniswap/v3-info/assets/97852365/5a1dd2c6-620d-4fd5-bee8-8e6634dffde5