fix: skip reprocessing event if already seen; also bunch of small optimizations #20
+124
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+23
to
+26
| impl From<DimensionName> for String { | ||
| fn from(dimension: DimensionName) -> Self { | ||
| match dimension { | ||
| DimensionName::Executor => EXECUTOR_DIMENSION.to_string(), |
There was a problem hiding this comment.
impl From gives you Into for free, the reverse not true
| @@ -44,21 +45,15 @@ impl FromStr for OrderType { | |||
| } | |||
| } | |||
|
|
|||
| impl ToString for OrderType { | |||
| fn to_string(&self) -> String { | |||
| impl fmt::Display for OrderType { | |||
There was a problem hiding this comment.
impl Display gives you ToString for free
| @@ -95,6 +95,10 @@ impl KeyStore { | |||
| pub fn len(&self) -> usize { | |||
| self.keys.len() | |||
| } | |||
|
|
|||
| pub fn is_empty(&self) -> bool { | |||
There was a problem hiding this comment.
pub fn len() and pub fn is_empty() often go hand-in-hand to provide the same interface as std types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.