-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[S3] Parse AWS configuration with support for profile section #2969
Conversation
Let me make sure I understand.
Have I stated the problem correctly? |
Exactly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best way to create a file in bash/sh is to use this method:
https://jinnabaalu.medium.com/create-a-file-in-bash-using-eof-af5af33c0d1f
Just checking in @DennisHeimbigner and @mannreis in regards to the latest changes requests. It looks like @mannreis made some changes, how does this look now @DennisHeimbigner ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more change, please. Remove the .aws directory at the end of the shell script so that automake distcheck will not fail.
Hello 👋!
I've faced a minor problem on my setup when I have a profile section on the configuration file [1] (valid with aws tools). In such case the netcdf library fails to load the AWS config, not critical but not obvious.
This is a quick fix I did for my myself, but looking at the parser and aws config specification I see parsing problems with:
I'm not sure to which extend you want to support loading the AWS config when the building with the internal S3 implementation.
Thanks!
[1]
~/.aws/credentials
~/.aws/config