Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper functions for 1D plots and kwargs optimization #25

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

nikhilbhavikatti
Copy link
Collaborator

[x] Add wrapper functions that support direct visualization for 1D plots
[x] Optimization of usage of kwargs

Resolves issues #10 and #23

Copy link
Collaborator

@marinaevers marinaevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think, this resolves #23 fully because the arguments also need to be considered in the higher-dimensional plots. We could merge it as it is now (after fixing the comments below), but we should keep #23 open.

uadapy/plotting/plots1D.py Outdated Show resolved Hide resolved
uadapy/plotting/plots1D.py Outdated Show resolved Hide resolved
uadapy/plotting/plots1D.py Outdated Show resolved Hide resolved
uadapy/plotting/plots1D.py Outdated Show resolved Hide resolved
uadapy/plotting/plots1D.py Outdated Show resolved Hide resolved
@marinaevers marinaevers merged commit 6769b41 into main Oct 7, 2024
@marinaevers marinaevers deleted the 1d_wrapper_kwargs branch October 7, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants