Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom changes for godot-rapier #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Custom changes for godot-rapier #1

wants to merge 7 commits into from

Conversation

Ughuuu
Copy link
Owner

@Ughuuu Ughuuu commented Jul 20, 2024

@Vrixyz
Copy link

Vrixyz commented Jul 26, 2024

It's a change we can consider for rapier, an example showcasing the kind of new setup this PR enables would help with upstreaming it 🤩

Also, extra care should be taken to avoid breaking a previously possible setup, which is difficult to assess here. a "migration guide" will probably be welcome.

To clarify, I'm not requesting these (hey it's your fork, thanks for making this in the open 😄), I'm voicing my interest and discussing a possible path forward for rapier 👍.

@Ughuuu
Copy link
Owner Author

Ughuuu commented Jul 26, 2024

Thanks for comments. The main problem currently with godot-rapier is in order to integrate into godot physics it needs to work in same way.

Friction and bounce works differently in rapier vanilla, this just makes it work same way as in godot. I could show examples or reference how it works in godot, but not sure if rapier would want to change its behaviours because godot does something in a specific way.

Layers and masks also work differently in godot. Collisions happen with an or instead of and, but it's a bit more complicated also. Godot also has asymetrical collisions. Meaning if A has layer 1 but no mask and B has layer 1 and mask 1, B will collide with A but A will not collide with B. https://docs.godotengine.org/en/stable/tutorials/physics/physics_introduction.html#collision-layers-and-masks

  • Now, on this, however could we implement this? Idk, godot jolt what does is it gives object A infinite mass and inertia in the collision so it seems like it doesnt interact.

Probably right now godot rapier is not big enough to say something like: this is how it works, deal with it. People aren't going to change their project in godot to work with different way godot rapier works. So for now at least, having some local changes might be expected, again unless rapier is willing to add them to rapier vanilla.

@Vrixyz
Copy link

Vrixyz commented Aug 9, 2024

@Ughuuu
Copy link
Owner Author

Ughuuu commented Aug 9, 2024

Perfect, if that gets in I can remove some parts of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants