Added option to export explanation csv for all files #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Udayraj123
reviewed
Oct 5, 2024
Udayraj123
reviewed
Oct 5, 2024
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| import pandas as pd | |||
| from rich.table import Table | |||
| from rich_tools import table_to_df | |||
There was a problem hiding this comment.
Oh actually I read it as rich.tools, is this a new package getting installed?
Need to update requirements.txt in that case
There was a problem hiding this comment.
yeah it is a new package, will update requirements.txt
There was a problem hiding this comment.
I was thinking if it should be abstracted inside evaluation only, entry.py doesn't need to know underlying tools getting used. Directly a way to access the df from evaluation_config_for_response
|
done |
Udayraj123
reviewed
Oct 7, 2024
Udayraj123
reviewed
Oct 7, 2024
…de should_export_explanation_csv
Udayraj123
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a should_export_csv flag in evaluation_schema, if this value is set to true, explanation_table is exported to csv and stored in Evaluations directory
Sample csv -
