[Feature] Simplify template jsons #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: simplify template schema and block logic; consume it; use fields terminology; update all samples fix: bug fixes
Udayraj123
added
enhancement
|
Project wiki changes here: 2481b1e3862795280091e9c7cd319453ffffdb0f |
fix: renaming fix: test
fix: refactor tests structure and add utils
Udayraj123
force-pushed
the
feature/simplify-template
branch
from
fc22a2e
to
fdbd24e
Compare
deepakgouda
approved these changes
Feb 10, 2023
src/schemas/constants.py
Outdated
|
|
||
| FIELD_STRING_TYPE = { | ||
| "type": "string", | ||
| "pattern": "^([^\\.]+)*?([^\\.\\d]+(\\d+)\\.{2,3}(\\d+))*?$", |
There was a problem hiding this comment.
Simpler regex:
Suggested change
| "pattern": "^([^\\.]+)*?([^\\.\\d]+(\\d+)\\.{2,3}(\\d+))*?$", | |
| "pattern": "^([^\\.]+|[^\\.\\d]+\\d+\\.{2,3}\\d+)$", |
Udayraj123
added a commit
that referenced
this pull request
Feb 12, 2023
* fix: load answer key from image with working samples * fix: pytests set up with snapshots for all samples * fix: run sample1 on pre-commit; run all tests on pre-push fix: add default_install_hook_types fix: add explicit stages * fix: update snapshots * fix: bug fixes * [Feature] Simplify template jsons (#127) * fix: update snapshots feat: simplify template schema and block logic; consume it; use fields terminology; update all samples fix: bug fixes * fix: refactor template.py; minor template json cleanup * fix: changes after updating wiki * feat: setup tests for template validations; fixed few bugs fix: renaming fix: test * fix: refactor fix: refactor tests structure and add utils * fix: minor fixes * fix: reorder imports; rename question -> field * fix: review changes * fix: remove streak logic
Udayraj123
added a commit
that referenced
this pull request
Feb 12, 2023
* fix: add upsc mock; refactor; create evaluation-schema fix: refactor; add sample evaluation.json fix: update gitignore and rename ignored folder fix: setup skeleton; refactor * fix: refactor; change defaults to .py; pickup config.json recursively; wip pass instance * fix: update evaluation-schema and sample json wip fix: refactor; connect evaluation schema fix: checked validation using evaluation schema * refactor: separate static vs instance ImageUtils; breakfown files further; move constants/configs to better places; fix: refactor; move instance ops to core; minor changes refactor: extract tuning config from instance fix: add screeninfo for simple window info * fix: load json error handling; dynamic config json working for sample5 * fix: use formatted strings at all places necessary * fix: correct config schema * fix: working evaluation code fix: evaluation schema fixes * fix: add range operator support; add validations for marking scheme and omr response * fix: add a sample with answer_key.csv * fix: minor fixes * fix: foundation for answer_key_image_path; refactoring; minor changes * fix: remove unnecessary comments; fix minor comments * fix: further on foundation for csv_from_image feature; refactoring * fix: stronger validations; conditionality in streak scheme; joinpath refactor * fix: support multi-correct and basic multi-weighted; update explanations * fix: csv load custom key support fix: additional warning * fix: add evaluation configs in some samples * fix: load answer key from image with working samples fix: compress images * fix: compress images * fix: update samples; add readme for template shift sample * fix: reduce images; minor changes * [Feature] setup pytest on existing samples (#124) * fix: load answer key from image with working samples * fix: pytests set up with snapshots for all samples * fix: run sample1 on pre-commit; run all tests on pre-push fix: add default_install_hook_types fix: add explicit stages * fix: update snapshots * fix: bug fixes * [Feature] Simplify template jsons (#127) * fix: update snapshots feat: simplify template schema and block logic; consume it; use fields terminology; update all samples fix: bug fixes * fix: refactor template.py; minor template json cleanup * fix: changes after updating wiki * feat: setup tests for template validations; fixed few bugs fix: renaming fix: test * fix: refactor fix: refactor tests structure and add utils * fix: minor fixes * fix: reorder imports; rename question -> field * fix: review changes * fix: remove streak logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR#3 of a chained PR.
Prev