Make Implementation, Algorithm, and their Dtos abstract #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
This PR is for the purpose of review. This is not a completed task.
The code is getting compiled but there are too many test cases failing (298).
Task: Implementation, ImplementationDto, Algorithm, AlgorithmDto should be abstract..
Issues Faced
ModelMapper changes.
Unable to use AlgorithmService in ModelMapperUtils. The instance of AlgorithmService is getting initialised as null. ModelMapper is used for class convertions in most of the test classes and controllers. Most of the test case failures are as of now is because of the ModelMapper.
AlgorithmRelation class has 2 fields which are of Algorithm type. So during runtime AlgorithmRelation class can no longer be instantiated. Is there anyway I can use either of two types for a field in a class.
Fixes: #