Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geospatial function updates #527

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from
Open

geospatial function updates #527

wants to merge 32 commits into from

Commits on Aug 29, 2024

  1. Geospatial function updates

    @kathryn-willi
    kathryn-willi committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    552177b View commit details
    Browse the repository at this point in the history

  2. Geospatial function updates

    @kathryn-willi
    kathryn-willi committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c90b14e View commit details
    Browse the repository at this point in the history

  3. package devel changes

    @kathryn-willi
    kathryn-willi committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    a075747 View commit details
    Browse the repository at this point in the history

  4. Geospatial function updates

    @kathryn-willi
    kathryn-willi committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    88b453a View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. wording changes

    @kathryn-willi
    kathryn-willi committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    18bb38f View commit details
    Browse the repository at this point in the history

  2. Update R/GeospatialFunctions.R 

    Co-authored-by: Matt Brousil <[email protected]>
    @kathryn-willi @mbrousil
    kathryn-willi and mbrousil authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a9e95fe View commit details
    Browse the repository at this point in the history

  3. Update R/GeospatialFunctions.R 

    Co-authored-by: Matt Brousil <[email protected]>
    @kathryn-willi @mbrousil
    kathryn-willi and mbrousil authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a202472 View commit details
    Browse the repository at this point in the history

  4. Update R/GeospatialFunctions.R 

    Co-authored-by: Matt Brousil <[email protected]>
    @kathryn-willi @mbrousil
    kathryn-willi and mbrousil authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    86064b9 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #3 from kathryn-willi/develop 

    GetATTAINS changes, error handling updates
    @kathryn-willi
    kathryn-willi authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    98c6038 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'USEPA:develop' into develop

    @kathryn-willi
    kathryn-willi authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    e85e351 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge branch 'develop' into pr/521

    @cristinamullin
    cristinamullin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f774df9 View commit details
    Browse the repository at this point in the history

  2. Update DESCRIPTION

    @cristinamullin
    cristinamullin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6d7e964 View commit details
    Browse the repository at this point in the history

  3. update description

    @cristinamullin
    cristinamullin authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    127f91c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into ROSSyndicate-review

    @cristinamullin
    cristinamullin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c52cc3f View commit details
    Browse the repository at this point in the history

  5. comment out TADA_ViewATTAINS lines 1485-1493 and run document

    @cristinamullin
    cristinamullin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5a34375 View commit details
    Browse the repository at this point in the history

  6. add arcgislayers dependency

    @cristinamullin
    cristinamullin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c6de230 View commit details
    Browse the repository at this point in the history

  7. Update DESCRIPTION

    @cristinamullin
    cristinamullin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7be0969 View commit details
    Browse the repository at this point in the history

  8. removed WIP code, added argis layers to remotes

    @kathryn-willi
    kathryn-willi committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    46e0b6d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Merge branch 'develop' of https://github.com/rossyndicate/EPATADA int… 

    …o pr/521
    @cristinamullin
    cristinamullin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ccee178 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'pr/521' into ROSSyndicate-review

    @cristinamullin
    cristinamullin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9585c85 View commit details
    Browse the repository at this point in the history

  3. Update TADA_GetATTAINS.Rd

    @cristinamullin
    cristinamullin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c395ea5 View commit details
    Browse the repository at this point in the history

  4. Update DESCRIPTION

    @cristinamullin
    cristinamullin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    656cdd1 View commit details
    Browse the repository at this point in the history

  5. better name for obj

    @kathryn-willi
    kathryn-willi committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3765aca View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. added in waterbodies and flowlines as fetchNHD() options

    @kathryn-willi
    kathryn-willi committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3db496d View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge branch 'pr/521' into ROSSyndicate-review

    @cristinamullin
    cristinamullin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    0c93172 View commit details
    Browse the repository at this point in the history

  2. Update DESCRIPTION

    @cristinamullin
    cristinamullin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7e14393 View commit details
    Browse the repository at this point in the history

  3. remote dependencies

    @cristinamullin
    cristinamullin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    710545e View commit details
    Browse the repository at this point in the history

  4. set eval = F for mod 2 vignette 

    arcgislayers is not available on CRAN so this causes check errors. Hopefully it will become available on CRAN again in the future
    @cristinamullin
    cristinamullin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2b537b5 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. update description and remove test 

    test-GeospatilFcuntions.R failing
lines 112-120

# fetchNHD ----
testthat::test_that(
  desc = "fetchNHD handles valid input data",
  code = {
    valid_data <- sf::st_sf(geometry = sf::st_sfc(sf::st_point(c(0, 0))), crs = 4326)
    result <- fetchNHD(.data = valid_data)
    expect_false(is.null(result))
  }
)
    @cristinamullin
    cristinamullin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b51e9aa View commit details
    Browse the repository at this point in the history

  2. try this 

    - update example data
- update WQX ref tables
- update Rmd to ref develop branch only
- try adding arcgislayers to imports
    @cristinamullin
    cristinamullin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    410de46 View commit details
    Browse the repository at this point in the history

  3. Update DESCRIPTION

    @cristinamullin
    cristinamullin committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e7f4ee5 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. update citation and description

    @cristinamullin
    cristinamullin committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    60c5cce View commit details
    Browse the repository at this point in the history