Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to WQX ref (ft, in, m) and TADA (mass/mass to mass/volume) ref #522

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Commits on Aug 29, 2024

  1. Add Pairing Functions

    hillarymarler committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9ad1555 View commit details
    Browse the repository at this point in the history
  2. Update CriteriaComparison.R

    Styler updates
    hillarymarler committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c59e4bb View commit details
    Browse the repository at this point in the history
  3. Add test

    hillarymarler committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    98fdaf5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d358be5 View commit details
    Browse the repository at this point in the history
  5. Update Utilities.R

    hillarymarler committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    2bb6264 View commit details
    Browse the repository at this point in the history
  6. Update Utilities.R

    hillarymarler committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    896a39b View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Documentation updates

    hillarymarler committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    6dc03d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9972be6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    883cc57 View commit details
    Browse the repository at this point in the history
  4. Update DESCRIPTION

    Added rlang to imports
    hillarymarler committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    087fa06 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Update TADAPriorityCharUnitRef.csv

    Hardness characteristics convert to mg/L as TADA priority
    hillarymarler committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6656f98 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eec2b55 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    ff0ee66 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Update CriteriaComparison.R

    Rank characteristics in pair ref by # of results in data frame
    hillarymarler committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    922ded2 View commit details
    Browse the repository at this point in the history
  2. Update CriteriaComparison.R

    Added comments in code
    hillarymarler committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    3517df7 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #519 from USEPA/392-create-function-to-find-paired…

    …-data-t-ph-hardness-dependent-criteria
    
    392 create function to find paired data t ph hardness dependent criteria
    hillarymarler authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    025f304 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. fix unit conversions

    - Updates reference tables and example data
    - Removes TADA.WQXTargetUnit and adds TADA.Target.ResultMeasure.MeasureUnitCode to required cols
    - Update ordering of columns and comparable data ID when transform = FALSE
    - Adds TADA.WQXUnitConversionCoefficient and TADA.WQXResultUnitConversion to column ordering (only relevant when transform = FALSE)
    - Update documentation
    cristinamullin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9cc90e4 View commit details
    Browse the repository at this point in the history
  2. Update TADA_FlagResultUnit

    - Allows function to run without autoclean being run first
    - found that PPM was "Accepted" unit for "Depth, Bottom". Changed this to "Rejected" in WQX validation table. Reviewed many other depth result units as well as part of this update.
    - Updated example data
    cristinamullin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c4bd279 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'origin/505-unit-conversions-massmass-vs…

    …-massvolume---kw' into fix-unit-conversions
    cristinamullin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    cb21913 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. TADA_CreateUnitRef and TADAPriorityCharConvertRef update

    Additional rows for other mass/mass to mass/volume
    
    Removed the two columns for TADA.WQXUnitConversionFactor and
    TADA.WQXUnitConversionCoefficient in the function TADA_CreateUnitRef
    wokenny13 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    afde8ea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ffd91c View commit details
    Browse the repository at this point in the history
  3. TADAPriorityCharConvertRef

    wokenny13 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    fae664f View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Update UnitConversions.R

    wokenny13 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9e04979 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Update UnitConversions.R

    Changed order of columns to make it more clear on which columns are using the conversion factor
    wokenny13 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4b31207 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Update test-CriteriaComparison.R

    The test_that should re-run the TADA_RandomTestingData pull up to 10 times for testdat1. It will stop and determine if dimensions are the same. if testdat2 is able to run without error, that is if paired parameters in the testdat1 are in its dataframe.
    wokenny13 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    01c40fd View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Update test-CriteriaComparison.R

    updated comments and styler
    wokenny13 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7d032b0 View commit details
    Browse the repository at this point in the history