Analysis data filter bug fix

USEPA · Sep 12, 2024 · 72deada · 72deada
1 parent 85a5ade
commit 72deada
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/R/Filtering.R b/R/Filtering.R
@@ -279,10 +279,9 @@ TADA_AnalysisDataFilter <- function(.data,
   # import MonitoringLocationTypeNames and TADA.Media.Flags
   sw.sitetypes <- utils::read.csv(system.file("extdata", "WQXMonitoringLocationTypeNameRef.csv", package = "EPATADA")) %>%
     dplyr::select(Name, TADA.Media.Flag) %>%
-    dplyr::rename(
-      ML.Media.Flag = TADA.Media.Flag,
-      TADA.MonitoringLocationTypeName = toupper(Name)
-    )
+    dplyr::rename(ML.Media.Flag = TADA.Media.Flag) %>%
+    dplyr::mutate(TADA.MonitoringLocationTypeName = toupper(Name)) %>%
+    dplyr::select(-Name)
 
 
   # add TADA.Media.Flag column

diff --git a/vignettes/TADAModule1_BeginnerTraining.Rmd b/vignettes/TADAModule1_BeginnerTraining.Rmd
@@ -83,7 +83,7 @@ console).
 
 ```{r install_TADA, eval = F, results = 'hide'}
 remotes::install_github("USEPA/EPATADA",
-  ref = "502-tadacomparabledataidentifier-column-showing-na-for-the-tadaresultmeasuremeasureunitcode-portion-of-its-string-pasting",
+  ref = "482-create-tadamonitoringlocationidentifier-in-tada_autoclean",
   dependencies = TRUE
 )