Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve class names #163

Open
jomey opened this issue Jun 10, 2020 · 1 comment
Open

Improve class names #163

jomey opened this issue Jun 10, 2020 · 1 comment
Labels
enhancement

Comments

@jomey
Copy link
Collaborator

jomey commented Jun 10, 2020

There are a few classes in SMRF, which do not follow PEP8 recommendations. For instance, smrf/distribute/cloud_factor.py uses cl as its class name.

This ticket is to go through the codebase and ensure that classes are easy to identify and follow PEP8 naming conventions.
@scotthavens
Copy link
Contributor

This has been bugging me for a while now!

This will break AWSM so this should be done in tandem with an AWSM PR.

@jomey jomey mentioned this issue Jun 10, 2020
Open
@scotthavens scotthavens mentioned this issue Jun 29, 2020
Open
@scotthavens scotthavens mentioned this issue Oct 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jomey @scotthavens