Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change smrf.data class naming conventions #171

Open
jomey opened this issue Jun 29, 2020 · 3 comments
Open

Change smrf.data class naming conventions #171

jomey opened this issue Jun 29, 2020 · 3 comments

Comments

@jomey
Copy link
Collaborator

jomey commented Jun 29, 2020

The files under smrf.data should be updated to match their classes they hold. Also rename the grid class, so we don't end up with references of grid.GRID

@scotthavens
Copy link
Contributor

I think this follows the line of #163 as the class names are not all that useful. For example, air temperature is in air_temp.ta. Would this be better as air_temp.AirTemp or put the class names in the __init__.py to import cleaner?

@jomey
Copy link
Collaborator Author

jomey commented Jun 29, 2020

We can combine these two tickets.

Only logged this separately as it looks like there could be some bigger restructuring of the load data logic once you open that can of worms.

I usually follow the pattern to put class names inside the __init__.py:
Example

@scotthavens
Copy link
Contributor

As SMRF is growing with more and more subpackages, having class names in the __init__.py starts to make a lot more sense. While it sounds simple, this will be a pretty decent undertaking, especially cleaning up of the data folder!

@jomey jomey mentioned this issue Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants