Floating Point Cleanup #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove throws from generated code - Block inlining on FPRecipEstimate - Convert enums to bvs as a post-transform - Alter semantics to permit int/enum comparison, improving coverage testing results
Match if (x = constant) then r := constant else ... patterns and attempt to replace with r := f x for simple mappings between constant pairs.
|
A small question about the zext, from the example in #46. Is the extend needed if it's only going to be used by cvt_bits_uint? In general, I think the int to bits convention is to treat bit vectors as signed. Is this why? |
|
I'd expect in that example it's because the FPRounding type is an enum with 6 possible values so to represent it as a bitvector you need 3 bits, but in that example it's being converted from a 2-bit value which corresponds to one of the first four enum values. |
|
How interesting! |
|
Yeah, the extend is due to the size of FPRounding type. The goal was to have consistent bit vector widths for arguments to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A series of improvements to improve the quality of floating point results. Mostly the conversion of enums to bit vectors and some cleanup around trivial case statements. Notably reduces coverage decompilation failures to only those instructions that refer to
FPToFixedJS, due to its tuple return.