Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Model Card Callback init in Trainer to a separate function #3047

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

tRosenflanz
Copy link
Contributor

Model Card Callback is now added/initialized in a separate function that can be disabled/customized by subclassing the trainer

#3016

@tomaarsen
Copy link
Collaborator

Hello!

Thanks a bunch for setting this up. I made some minor changes: renamed the method & added a docstring which should look like this in the new documentation:

image

I'll merge this once the tests go green!

  • Tom Aarsen

@tomaarsen
Copy link
Collaborator

Looks like I can't move the default_args_dict to after the super().__init__() due to some magic by accelerate. I reverted that change.

  • Tom Aarsen

@tomaarsen tomaarsen merged commit 6347b75 into UKPLab:master Nov 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants