Add support for M2M100EncoderModel (aka NLLB, aka SONAR text encoder) #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I'll be glad to merge this if Transformers accepts your work. Feel free to ping me when that happens.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft pull request for supporting SONAR text encoder model.
SONAR encoder is architecturally an encoder from NLLB, which is, in turn, is implemented as M2M100 in HF Transformers.
Thus, I support the encoder-only part of it, in the same way as T5-based encoders are currently supported.
This PR depends on a pull request to Transformers huggingface/transformers#29646, and should be reviewed only after that one.
Probably, the minimal required version of Transformers should also be updated to point to a release after the aforementioned PR is merged.