Passing arbitrary keyword arguments to submodules #2539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a prototype of the proposal #2538. I.e., it allows arbitrary keyword arguments to be passed through
SentenceTransformer.encode
to the model.Users may now specify in
modules.json
what keyword arguments are expected by which module. TheSentenceTransformer
class no longer inherits fromnn.Sequential
, but instead fromnn.ModuleDict
. We implement theforward
method ourselves and distribute keyword arguments to the modules.A model may then provide a
modules.json
file like this:and users may use the sentence-transformer model like this:
Todo
.append
method, which was previously inherited fromnn.Sequential
. However, we could also implement it here