Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eval_batch_size argument to cross encoder evaluators #2284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yunyu
Copy link

@yunyu yunyu commented Aug 24, 2023

Cross encoder eval can be very slow, especially if you can fit way bigger batch sizes than the default. This PR allows passing in eval_batch_size to cross encoder evaluators

@fkdosilovic
Copy link
Contributor

fkdosilovic commented Feb 26, 2024

This is a useful addition as far as I'm concerned. @yunyu Would you also like to add an option to pass the show_progress_bar argument in the same PR (if @tomaarsen agrees)?

cc @tomaarsen

@tomaarsen
Copy link
Collaborator

Apologies for the delay! I would indeed be interested in batch_size and show_progress_bar options for all CE Evaluators.

  • Tom Aarsen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants