Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI and refactoring example. #1688

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add CLI and refactoring example. #1688

wants to merge 3 commits into from

Conversation

Yur-or
Copy link

@Yur-or Yur-or commented Sep 8, 2022

Made a change to one of the examples of training multilingual. Added a command line interface to this example and made minor changes linked with syntax and PEP8. Also, split the code into several logical functions.
It seems that this will help those who want to use multilingual and do it according to the repository examples. If these changes are helpful, I might do the same with the rest of the examples.

Corrected PEP8 and up-to-date syntax.
Example implementation CLI was taken from transformers examples.
Creation of the main function, moved the logical blocks into different functions and a little more refactoring.
@Yur-or
Copy link
Author

Yur-or commented Nov 21, 2022

@nreimers, good day! :)
Could you look at this PR and check if this could be merged?
I think it can be helpful for guys who would like to use sentence-transformers or would like to understand how it works.
Let me know if I should change something :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant