Fixed silentLogin cardOrder bug #2034
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the issue, removing the print statements, and cleaning up all the changes
Don't need the app constants that I added
Fully implemented the functionality of the previous version of the temporary fix
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in silentLogin that causes #1899
Changelog
[General][Fix] - Fixes a bug that caused the cardOrder to be overwritten every silentLogin. Switched it to loadSavedData() in user.dart
[General][Fix] - Refactored one small part of cards.dart for better readability and functionality
Test Plan
This pull request changes the log-in procedure (for silentLogin). Reviewers should test the login and ensure that their card order remains the same every time they open and close the app (and are logged in)