Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All of my changes so far! #5

Merged
merged 5 commits into from
Sep 12, 2023
Merged

All of my changes so far! #5

merged 5 commits into from
Sep 12, 2023

Conversation

kristinawlai
Copy link
Collaborator

I guess I didn't know how to create a pull request before now! This includes my edits to the readme, changing all package names to "serocalculator", and beginning updates to the new typhoid vignette.

@d-morrison
Copy link
Member

Nice work setting up this PR! Let's try two more steps:

  1. add me as a reviewer for this PR (see the Reviewers pane near the top right)
  2. merge the "main" branch from UCD-SERG into the "main" branch on your fork. If you go to https://github.com/kristinawlai/serocalculator/, you should see a message:

"This branch is [4 commits ahead] [5 commits behind] UCD-SERG:main."

Clicking on the [5 commits behind] part should set up the merge for you; if you get stuck, let me know!

Thanks,
Ezra

@d-morrison
Copy link
Member

PS - the reason for 2 is to try to resolve the check errors above; if that doesn't do the trick, we should take a closer look at those errors and try to resolve them.

@d-morrison
Copy link
Member

PPS - I made some conflicting changes to the readme, so I added a commit resolving those conflicts. We still have to resolve the check errors though.

@kristinawlai kristinawlai merged commit 212b655 into UCD-SERG:main Sep 12, 2023
0 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants