Quickfix/efvignette/logscale #308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
|
📖 https://ucd-serg.github.io/serocalculator/preview/pr308 |
d-morrison
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Thanks for this PR! Two questions:
- Why are we applying the log scale manually instead of with the
log = TRUEoption forautoplot.pop_data()? - @kaiemjoy, is this how we want the x-axis label for this graph? (preview here: https://ucd-serg.github.io/serocalculator/preview/pr308/articles/enteric_fever_example.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying log scale in second cross-sectional antibody data plot