reconciling cran-fixes with main: autoplot.curve_params

[kristinawlai]

Review to remove conflicts between CRAN-fixes and main

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
R/autoplot.curve_params.R	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
R/autoplot.curve_params.R	0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

[d-morrison]

I'm approving this PR; see one minor comment below about line-breaking after each sentence. Also, the test coverage for this PR is too low (it's at 0%), which I usually wouldn't allow; I'm not sure why the system marked it as a success. I'm ignoring it this one time, since we are rushing to get you focused on the QE, but we need you to learn how to write unit-tests asap after that (and possibly sooner; I'll let you know if it becomes unavoidable).

[d-morrison]

In general, please line-break after every sentence; it makes code review easier later on.

[kristinawlai]

@d-morrison question about this... in this case the sentences were too long to pass through linting (>80 characters), which is why I had to break them at weird points. What do you suggest for the future?

[d-morrison]

@kristinawlai ideally, add line breaks at all sentence ends and also at additional points to make all lines less than 80 characters; good places to break are after commas and before/after grammatical substructures (noun-phrases, verb-phrases, etc). I've recently started experimenting with turning my prose source code into an almost poetry-style format; the compiler will ignore single line breaks anyway and convert it back into a "normal" format, so you can have some fun with the source code formatting.

[kristinawlai]

Thanks @d-morrison! I'm also surprised that it passed checks without the unit tests... it did not pass them earlier and I was looking them up. Decided to submit it anyways since it passed though haha! Definitely on my radar.