add error message for missing strata #227
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,7 +49,7 @@ | |
| #' curve_params = curve, | ||
| #' noise_params = noise %>% filter(Country == "Pakistan"), | ||
| #' antigen_isos = c("HlyE_IgG", "HlyE_IgA"), | ||
| #' # num_cores = 8 # Allow for parallel processing to decrease run time | ||
| #' iterlim = 5 # limit iterations for the purpose of this example | ||
| #' ) | ||
| #' | ||
|
|
@@ -101,6 +101,27 @@ | |
| return(to_return) | ||
| } | ||
|
|
||
| if (!any(is.element(strata,pop_data %>% names()))) { | ||
| # search strata variable from pop_data | ||
| strata_var <- | ||
| grep( | ||
| x = pop_data %>% names(), | ||
| value = TRUE, | ||
| pattern = strata, | ||
|
There was a problem hiding this comment. what happens here if There was a problem hiding this comment. This is in order and adds complexity to Issue #233. For example, if Addendum: |
||
| ignore.case = TRUE | ||
| ) | ||
|
|
||
| cli::cli_abort( | ||
| class = "missing_var", | ||
| message = c( | ||
| "Can't find the column {.var {strata}} in {.envvar pop_data}.", | ||
|
There was a problem hiding this comment. please revise this inline markup; There was a problem hiding this comment. This is well-noted. |
||
| if (length(strata_var) > 0) { | ||
| "i" <- "Did you mean {.var {strata_var}}." | ||
|
There was a problem hiding this comment. Please end questions with a question mark instead of a period. There was a problem hiding this comment. This has been implemented. |
||
| } | ||
|
There was a problem hiding this comment. please add a test that covers this case There was a problem hiding this comment. This has been implemented. |
||
| ) | ||
| ) | ||
| } | ||
|
|
||
| .checkStrata(data = pop_data, strata = strata) | ||
|
|
||
| .errorCheck( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please always format according to the style guide (add a space after the comma in
strata,pop_data, etc)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change has been made.