fixing warnings in check() #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added Kristen and Kristina to authors list. added return value information in .nll() function documentation.
|
Here, I'm creating a pull request (using the github.com interface). When I create the pull request, Github automatically runs the Github Actions checks that we were looking at before (they should be visible below this comment). |
|
The checks all passed! |
|
Super!!
From: Douglas Ezra Morrison ***@***.***>
Date: Friday, July 28, 2023 at 10:57 AM
To: UCD-SERG/serocalculator ***@***.***>
Cc: Kristen Aiemjoy ***@***.***>, Review requested ***@***.***>
Subject: Re: [UCD-SERG/serocalculator] fixing warnings in check() (PR #2)
The checks all passed!
—
Reply to this email directly, view it on GitHub<#2 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD253BWI7DRFMCEDFKSHORLXSM2BVANCNFSM6AAAAAA225WISA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
**CONFIDENTIALITY NOTICE** This e-mail communication and any attachments are for the sole use of the intended recipient and may contain information that is confidential and privileged under state and federal privacy laws. If you received this e-mail in error, be aware that any unauthorized use, disclosure, copying, or distribution is strictly prohibited. If you received this e-mail in error, please contact the sender immediately and destroy/delete all copies of this message.
|
kristinawlai
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed \cr (carriage return) symbols, and <> from emails in roxygen, added Kristen and Kristina to authors list. added return value information in .nll() function documentation.