make requested changes

UCD-SERG · Aug 26, 2024 · 8353600 · 8353600
1 parent 78131c1
commit 8353600
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/R/as_noise_params.R b/R/as_noise_params.R
@@ -62,11 +62,14 @@ as_noise_params <- function(data, antigen_isos = NULL) {
     if (!all(
       is.element(antigen_isos, noise_data$antigen_iso)
     )) {
+
+      missing_antigen <- setdiff(antigen_isos,
+                                 unique(noise_data$antigen_iso))
       cli::cli_abort(
         class = "missing_antigen",
         message = c(
-          "x" = "Can't convert {.envvar noise_data} to {.cls noise_params}.",
-          "i" = ""
+          "x" = "Can't convert {.var data} to {.cls noise_params}.",
+          "i" = "The antigen type{?s} {missing_antigen} {?is/are} missing in {.var data}"
         )
       )
     }

diff --git a/tests/testthat/test-as_noise_params.R b/tests/testthat/test-as_noise_params.R
@@ -28,5 +28,6 @@ test_that("`as_noise_params()` produces error when wrong antigen_iso is provided
 
   expect_error(object = "https://osf.io/download//hqy4v/" %>% # noise data
     readr::read_rds() %>%
-    as_noise_params(antigen_iso = "HlyE_IgB"))
+    as_noise_params(antigen_iso = "HlyE_IgB"),
+    class = 'missing_antigen')
 })