Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Python 3.12 #43

Merged
merged 12 commits into from
Dec 18, 2023
Merged

Update to Python 3.12 #43

merged 12 commits into from
Dec 18, 2023

Conversation

douglatornell
Copy link
Member

@douglatornell douglatornell commented Oct 16, 2023

  • Add Python 3.12 to GHA pytest-with-coverage workflow so that we can use the workflow to test whether all the packages moad_tools depends on have been updated to support Python 3.12.
  • Add workflow_dispatch trigger to GHA pytest-with-coverage workflow to enable workflow to be triggered from
    GitHub CLI, browser or via API
  • Drop Python 3.8, 3.9 & 3.10 from GHA pytest-with-coverage workflow
  • Change setup.cfg python_requires to >=3.11
  • Change conda environment descriptions to use Python 3.12
    • environment-dev.yaml
    • environment-rtd.yaml
  • Change sphinx-linkcheck workflow to Python 3.12
  • Change pkg dev doc & README to Python 3.12 for package development

This lets us use the workflow to test whether all the packages NEMO-Cmd depends
on have been updated to support Python 3.12.
Enables workflow to be triggered from GitHub CLI, browser, or via API.

This is primarily to allow the workflow to be run via
    gh workflow run pytest-with-coverage --ref py312
during the conda-forge Python 3.12 migration to test if the environment is
solvable yet.
@douglatornell douglatornell added the maintenance Package or repo maintenance label Oct 16, 2023
@douglatornell douglatornell added this to the v22.2 milestone Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff4863c) 56.54% compared to head (b1a10be) 56.36%.

❗ Current head b1a10be differs from pull request most recent head 1f019cb. Consider uploading reports for the commit 1f019cb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   56.54%   56.36%   -0.19%     
==========================================
  Files          12       12              
  Lines        1107     1107              
==========================================
- Hits          626      624       -2     
- Misses        481      483       +2     
Flag Coverage Δ
unittests 56.36% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dependabot bot and others added 10 commits October 18, 2023 11:56
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.0.6 to 2.0.7.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.0.6...2.0.7)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pip](https://github.com/pypa/pip) from 23.2.1 to 23.3.
- [Changelog](https://github.com/pypa/pip/blob/main/NEWS.rst)
- [Commits](pypa/pip@23.2.1...23.3)

---
updated-dependencies:
- dependency-name: pip
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
They are now just outdated maintenance overhead.
Update shapely testing function re: "ShapelyDeprecationWarning: The
'almost_equals()' method is deprecated and will be removed in Shapely 2.1".
@douglatornell douglatornell merged commit 9f2ef0f into main Dec 18, 2023
6 checks passed
@douglatornell douglatornell deleted the py312 branch December 18, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package or repo maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant