Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF fixes #341

Merged
merged 15 commits into from
Dec 28, 2023
Merged

PDF fixes #341

merged 15 commits into from
Dec 28, 2023

Conversation

trevorcampbell
Copy link
Contributor

@trevorcampbell trevorcampbell commented Dec 28, 2023

Also closes #339

Intro:

  • fixed fake running cell (uses two {code-cell} blocks now, one with hidden output, one with hidden input and a print stmt)
  • shortened section title to fit on one line
  • removed extra newline in code block
  • manual todo: layout of table 1 in chapter intro

Reading:

  • fixed fake running cells

Wrangling:

  • fixed fake running cells
  • manual todo: images too small

Viz:

  • manual todo: viz mouse hover image too big
  • manual todo: the histogram bin sizing image too tall
  • removed some unnecessary whitespace in an eqn to avoid an ugly linewrap

Cls1:

  • centered figures
  • handled pdf vs html build for 3d figs
  • manual todo: resize 3d fig

Cls2:

  • manual todo: figs too small (fig 1)
  • manual todo: fix the randomness/seeds code/output environments

Reg1:

  • manual todo: under/overfitting figure too big (fig 7)
  • handled pdf vs html build for 3d figs
  • manual todo: resize 3d fig

Reg2:

  • handled pdf vs html build for 3d figs
  • manual todo: resize 3d fig

Clustering:

  • manual todo: clustering unlucky iteration figure too tall (fig 10)

Inference:

  • no changes necessary

Jupyter:

  • changed ▸ to unicode for play (because PDF doesn't work with these anyway, may as well use proper unicode play/ffwd symbols in HTML and manually fix in PDF)
  • manual todo: change ⼵ to \faPlay, change ⏭ to faFastForward, and add \usepackage{fontawesome}

Version Control:

  • no changes necessary

Setup:

  • used {code-cell} blocks with :tags: ["remove-output"] for non-running code (better PDF formatting...)

All:

  • fixed some bib entries
  • manual todo: remove empty references subsections
  • manual todo: format the frontmatter (add * for chapters, parts, and acks subsec)
  • manual todo: format the author list (use \and)
  • manual todo: URLs don't print as footnotes. So all the hyperlink URLs don't actually work in print. E.g. the additional resources section in the reading chapter.

Copy link

Hello! I've built a preview of your PR so that you can compare it to the current main branch.

  • PR deploy preview available here
  • Current main deploy preview available here
  • Public production build available here

@trevorcampbell trevorcampbell marked this pull request as ready for review December 28, 2023 23:27
@trevorcampbell trevorcampbell merged commit c485fd1 into main Dec 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain figure hyperlinks point to captions, others to image
1 participant