Update to altair 5.1.2 to fix histrogram chart #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelostblom
commented
Oct 11, 2023
| @@ -18,7 +18,7 @@ RUN pip install docutils==0.17.1 # Need to pin docutils to an old version for no | |||
| RUN pip install referencing | |||
| RUN pip install jupyter-book | |||
| # Pinning pandas until altair 5.1.2 to avoid future warning https://github.com/altair-viz/altair/issues/3181 | |||
| RUN pip install numpy jinja2 pandas"<2.1" altair">=5.1.1" "vegafusion[embed]" vl-convert-python">=0.13" click ibis-framework ghp-import jupytext nodejs lxml | |||
| RUN pip install numpy jinja2 pandas altair">=5.1.2" "vegafusion[embed]" vl-convert-python">=0.14" click ibis-framework ghp-import jupytext nodejs lxml | |||
There was a problem hiding this comment.
the vl-convert bump is needed to go with altair 5.1.2 and the pandas restriction is no longer necessary as that warning was removed in 5.1.2
|
nevermind it did, it just thinks that the dockerfile wasn't edited...ugh
fixed, edited the dockerfile with an empty commit to trigger the deploy preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chart above the "Choosing a binwidth" heading is not showing up correctly (the histograms are missing). I am not sure what the exact issue is but upgrading altair in the docker image and rebuilding fixed it for me locally, so I'm suggesting we do that.
Oddly enough this issue does not show up in jupyter lab, just when building the charts via jupyter book.
Current:
After fix (the figure number is different because I didnt' build the entire book locally to save time):
