Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile - #1027 #1030

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nosbig
Copy link

@nosbig nosbig commented Nov 20, 2023

Updating Dockerfile to resolve #1027 in upstream project; applying updated permissions for the node module for youtube-dl. Additionally, this will resolve #730 and #997.

Updating Dockerfile to resolve Tzahi12345#1027 in upstream project; applying updated permissions for the node module for youtube-dl.
@martadinata666
Copy link
Collaborator

You should look at the youtube-dl binary updater here instead dockerfile. This script downloads the youtube-dl binary update if exists https://github.com/Tzahi12345/YoutubeDL-Material/blob/master/backend/youtube-dl.js.

@Tzahi12345
Copy link
Owner

Hi @nosbig, I recently merged a PR which may fix this issue. Basically all youtube-dl binaries now end up in appdata/bin, and they are named youtube-dl, yt-dlp, or youtube-dlc. So the chmod should probably look like this:

RUN chmod +x /app/appdata/bin/*

Either way I added the following line which may or may not solve this issue:

fs.chmod(output_path, 0o777);

Can you check if you can reproduce this in the latest nightly, and if so make the above change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot Download Youtube Videos - SOLVED Error while retrieving info on video with URL
3 participants