Skip to content

Commit

Permalink
Include symbols into install/lib/libcobalt.so (youtube#1857)
Browse files Browse the repository at this point in the history
To speed up the SB16 development process, include some symbols
(-gline-tables-only) into install/lib/libcobalt.so.

This change affects devel and debug builds only.

b/307760111
  • Loading branch information
maxz-lab authored Oct 31, 2023
1 parent 7e847b9 commit 6da4a2d
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 8 deletions.
4 changes: 2 additions & 2 deletions starboard/build/config/modular/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ config("modular") {
]
if (!cobalt_fastbuild) {
cflags += [
# This flag causes an increase in binary size on certain platforms. Refer b/297357707
"-g",
# Use -gline-tables-only to ease the impact of increased size. Refer b/307760111
"-gline-tables-only",
]
}
} else {
Expand Down
21 changes: 15 additions & 6 deletions starboard/evergreen/shared/strip_install_target.gni
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,20 @@ template("strip_install_target") {

outputs = [ "$sb_install_output_dir/$install_subdir/$source_name" ]

args = [
strip_executable,
"-o",
rebase_path(outputs[0], root_out_dir),
rebase_path("$root_out_dir/$source_name", root_out_dir),
]
# skip stripping to make sure we have some debug symbols. Refer b/307760111
if (is_devel) {
args = [
"cp",
rebase_path("$root_out_dir/$source_name", root_out_dir),
rebase_path(outputs[0], root_out_dir),
]
} else {
args = [
strip_executable,
"-o",
rebase_path(outputs[0], root_out_dir),
rebase_path("$root_out_dir/$source_name", root_out_dir),
]
}
}
}

0 comments on commit 6da4a2d

Please sign in to comment.