More autoformatting #2359
Merged
More autoformatting #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2359 +/- ##
==========================================
- Coverage 86.83% 86.67% -0.16%
==========================================
Files 24 24
Lines 1595 1599 +4
==========================================
+ Hits 1385 1386 +1
- Misses 210 213 +3 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11178383782Details
💛 - Coveralls |
torfjelde
approved these changes
Oct 4, 2024
This is exactly what somebody trying to introduce a subtle exploit would say 🤔 |
My statement was indeed incomplete: If you trust JuliaFormatter and me, you only really need to review the changes in .JuliaFormatter.toml. |
penelopeysm
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Bring more files into autoformatting fold * Run JuliaFormatter * Remove trailing whitespace * Update comment in .JuliaFormatter.toml
yebai
pushed a commit
that referenced
this pull request
Oct 23, 2024
* CompatHelper: bump compat for DynamicPPL to 0.29, (keep existing compat) (#2339) Co-authored-by: CompatHelper Julia <[email protected]> * CompatHelper: bump compat for DynamicPPL to 0.29 for package test, (keep existing compat) (#2340) Co-authored-by: CompatHelper Julia <[email protected]> * Replace vectorize(d, r) -> DynamicPPL.tovec(r) vectorize was removed in DynamicPPL 0.29.0 * Require Julia >= 1.9 * Add Julia 1.9 tests back * Fix essential/ad tests * Fix reconstruct calls in MH * Update src/mcmc/mh.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Require Julia 1.10 * Change 1 -> I in MvNormal() setting a real number as σ is deprecated * Simplify tests as we no longer support Julia <1.8 * Simplify `set_namedtuple!` * Remove conditional loading/exporting of Tapir * Tapir -> Mooncake * Update src/essential/Essential.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Remove Requires from Project.toml * Bump minor version instead * Restrict ADTypes to 1.9.0 for AutoMooncake() * Re-enable Mooncake tests in mcmc/abstractmcmc * Update the currently buggy and incorrect tilde overloads in `mh.jl` (#2360) * More autoformatting (#2359) * Bring more files into autoformatting fold * Run JuliaFormatter * Remove trailing whitespace * Update comment in .JuliaFormatter.toml * Fix bad merge * Restrict Mooncake to >= 0.4.9 * Add MH test for LKJCholesky * Remove Tracker * Format imports Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Add AD imports to Optimisation test * Bump Mooncake compat in tests * Bump Libtask version * Get Optimization tests to pass CI * Update API docs * Write a changelog entry * Update docs/src/api.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: CompatHelper Julia <[email protected]> Co-authored-by: Tor Erlend Fjelde <[email protected]> Co-authored-by: Markus Hauru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back when we introduced autoformatting in CI, we had a few big PRs in the works that would have caused horrendous merge conflicts. Hence some exceptions were added, where a few files that were being heavily worked on were marked to be ignored by JuliaFormatter. Several of those PRs have now been merged, so it could be time to start applying formatting to those files too.
This PR does exactly three things:
If you trust JuliaFormatter, you only really need to review the changes in .JuliaFormatter.toml.
I still had to leave a couple of exceptions in for files that are being removed by #2328 or heavily edited by #1887. Some smaller merge conflicts I considered acceptable.