Rent logic #46
Open
Rent logic #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- need to add headings to distinguish top trans from top rent - need to reformat so all neighborhood show
chompasina
reviewed
Oct 26, 2016
| $('#return-addresses').append(createNeighborhoodHTML(data[0][i])); | ||
| } | ||
| for (var i = 0; i < data[1].length; i++) { | ||
| $('#return-rent').append(createNeighborhoodRentHTML(data[1][i])); |
There was a problem hiding this comment.
I think this is a good temporary solution to have both neighborhood priorities listed on the page.
chompasina
reviewed
Oct 26, 2016
|
|
||
| def find_closest_rent_neighborhoods(user_max_rent) | ||
| max_avg_rent = user_max_rent * 1.2 | ||
| neighborhoods = Neighborhood.where('rent <= ?', max_avg_rent).order(rent: :desc).limit(3) |
There was a problem hiding this comment.
I'm curious how we decided to do 120% of their suggested rent. It might be good to test over time to make sure the top three neighborhood averages are at least reaching below the user-provided rent. What do you think?
chompasina
reviewed
Oct 26, 2016
| neighborhoods = Neighborhood.where('rent <= ?', max_avg_rent).order(rent: :desc).limit(3) | ||
| if neighborhoods.empty? | ||
| Neighborhood.order(:rent).limit(3) | ||
| else |
There was a problem hiding this comment.
This alleviates my previous concern, but might be good to do some testing to see how often the neighborhoods are returning empty arrays.
And comments out "add top rent neighborhoods" in case it was something else we needed.
|
@icorson3 Would you be able to review this PR along with me? I approve, but since it's adding functionality I'd like additional review before merging. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functioning according to interim plan of having top three rent results displayed along with top three transportation results.
View does not fit all six results currently - but may not be worth fixing at this time because we may ultimately decide to return three integrated neighborhoods.