[wip] Added comments ordering #12347
ci.yml
on: pull_request
Setup
1m 8s
Matrix: job_unit-tests
Matrix: job_database-tests
Matrix: job_regression-tests
i18n
36s
Browser tests
0s
Admin-X Settings tests
0s
Comments-UI tests
1m 36s
Signup-form tests
0s
Ghost-CLI tests
3m 54s
Performance tests
0s
Coverage
0s
Publish @tryghost/admin-x-activitypub
0s
Canary
0s
Annotations
5 errors and 2 warnings
Comments-UI tests
Process completed with exit code 1.
|
Database tests (Node 18.12.1, mysql8)
Process completed with exit code 1.
|
Database tests (Node 20.11.1, mysql8)
The job was canceled because "_18_12_1_mysql8_testing-m" failed.
|
Database tests (Node 20.11.1, mysql8)
The operation was canceled.
|
All required tests passed or skipped
Process completed with exit code 1.
|
Setup
The following actions use a deprecated Node.js version and will be forced to run on node20: AurorNZ/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Database tests (Node 18.12.1, mysql8):
ghost/core/test/e2e-api/members-comments/comments.test.js#L390
Retried 'Comments API when commenting enabled for all when authenticated Can sort comments by newest' due to '"response.body" does not match snapshot.
Snapshot name: `Comments API when commenting enabled for all when authenticated Can sort comments by newest 1: [body] 1`
- Expected properties - 14
+ Received value + 1
@@ -10,24 +10,11 @@
"liked": Any<Boolean>,
"member": Object {
"id": StringMatching /\[a-f0-9\]\{24\}/,
"uuid": StringMatching /\[a-f0-9\]\{8\}-\[a-f0-9\]\{4\}-\[a-f0-9\]\{4\}-\[a-f0-9\]\{4\}-\[a-f0-9\]\{12\}/,
},
- "replies": Array [
- Object {
- "count": Object {
- "likes": Any<Number>,
- },
- "created_at": StringMatching /\\d\{4\}-\\d\{2\}-\\d\{2\}T\\d\{2\}:\\d\{2\}:\\d\{2\}\\\.000Z/,
- "id": StringMatching /\[a-f0-9\]\{24\}/,
- "liked": Any<Boolean>,
- "member": Object {
- "id": StringMatching /\[a-f0-9\]\{24\}/,
- "uuid": StringMatching /\[a-f0-9\]\{8\}-\[a-f0-9\]\{4\}-\[a-f0-9\]\{4\}-\[a-f0-9\]\{4\}-\[a-f0-9\]\{12\}/,
- },
- },
- ],
+ "replies": Array [],
},
Object {
"count": Object {
"likes": Any<Number>,
},'
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
comments-ui-playwright-report
|
1.85 MB |
|
unit-coverage
|
371 KB |
|